In general, a hardware firewall beats a software firewall every time. XPs firewall offers some basic protection, but I would not rely on it.
From an 'average user' standpoint, there's nothing to easily misconfigure with a hardware firewall, and you cannot easily disable the firewall protection on a hardware firewall.
The fatal flaw with XPs firewall is that you can turn it off, AND it can be turned off programmatically, AND exceptions can be added programmatically to it as well.
This means that a virus you catch from joe scipt-kiddie, such as Bagz, XGQ, and others can and will shut off the firewall. So, in a way, the XP firewall is only as good as your Malware/Virus protection. So the castle walls are made of hefty stones, but the mortar is made of Jello pudding.
The XP firewall, when properly configured, is reasonably secure from very basic outside attacks (it blocks all inbound traffic).
Not to confuse the issue, but another concern is that the Windows firewall does not block or notify the user of suspicious outbound traffic.
Something like ZoneAlarm does block and detect outbound traffic.
Of course a typical soho NAT firewall doesn't block outbound traffic either....
So here it is in a nutshell:
Best: Hardware-based NAT firewall and Personal Firewall such as ZoneAlarm.
Good: Hardware-based NAT firewall and XP firewall (though somehwat overlapping functionality).
Not-so-good: XP firewall only. Could be compromised through user error and/or malware.