5 replies
by realgem
Part of the best practice is to ensure that your reviewers all have a copy of the specs as well as the code, and ample time to review the code. Make sure that they have several days, and that this time is allowed for in the project plan. If you don't, then the reviewers won't be able to do a good enough job, and the peer reviews will fail.
You should be reviewing things like:
- adherence to coding standards (variable naming, documentation, use of standard libraries, etc.)
- good codingpractices. e.g. did the author use subroutines to handle the window-closing function instead of duplicating the code in various buttons and menus.
- delivery of specs. Did the author attempt to code all of the specification?
You benefits willinclude:
- reduced maintenance costs
- smaller, more efficient, code sets
- improved quality: fewer defects, fewer missed requirements
- junior staff can learn from reviewing the work of senior staff, and avoid making some of those mistakes themselves.
- senior staff get an opportunity to mentor junior people.
I recommend that you get a copy of "Code Complete" by Steve McConnell, published by Microsoft Press. It's a very excellent book, and very popular, and will give some good tips, plus help you with quantifying the benefits.
Note that you should not review absolutely every line of code. This will be less effective and will probably cause a mutiny. Select the most important (i.e. data updates, complex calculations) modules for review, and do them well.
Ensure that your review team consists of people who are not on the project. The code should be readable by these people, too.
by david.foley
by wayne m.
Take a look at http://www.sei.cmu.edu/ THere is also a related site "SEIR" which contains a lot more data, but you have to register for it. The registration is free and I have not recieved any spam based upon my registration.
I tough question Ihave to ask you, though, is if you have no clear understanding of any benefits to this proactice, why are you proposing it? Without a clear procedure and set of benefits, most peer reviews devlove into a bureaucratic record keeping process which istypically ignored. This is why your task leads and project management are rejecting your proposal. You will need a lot more information that a quick bullet list to convince them otherwise.
by david.foley
by david.foley
This discussion is closed to new replies.
Trending IT Employment posts
Sort by Trending