Hello! I found a script yesterday on this site that creates users in AD from a csv file. Before I added 4 more entries for description,login script, home directory, and homedrive I was getting a loop detected. After adding the entries I get an “unterminated string constraint on line 40 (the “oNewUser.put “description?,sDescription” line).
Any thoughts would be greatly appreciated!
Here is the script:
Dim sCSVFile
Dim oConnection
Dim oRecordSet
Dim oNewUser
‘ Variables needed for LDAP connection
Dim oRootLDAP
Dim oContainer
‘ Holding variables for information import from CSV file
Dim sLogon
Dim sFirstName
Dim sLastName
Dim sDisplayName
Dim sPassword
Dim nPwdLastSet
Dim nUserAccountControl ‘ Used to enable the account
Dim sDomain
Dim sDescription
Dim sHomeDrive
Dim sHomeFolder
Dim sLoginScript
‘ Modify this to match your company’s AD domain
sDomain=”foobar.local”
‘ Input file location
sCSVFileLocation = “C:\Scripts\” ‘KEEP TRAILING SLASH!
‘ Full path to input file
sCSVFile = sCSVFileLocation&”Book2.csv”
‘ Commands used to open the CSV file and select all of the records
set oConnection = createobject(“adodb.connection”)
set oRecordSet = createobject(“adodb.recordset”)
oConnection.open “Provider=Microsoft.Jet.OLEDB.4.0;Data Source= ” & sCSVFileLocation & “;Extended Properties=””text;HDR=NO;FMT=Delimited”””
oRecordSet.open “SELECT * FROM ” & sCSVFile ,oConnection
‘ Create a connection to the Active Directory Users container.
Set oRootLDAP = GetObject(“LDAP://rootDSE”)
Set oContainer = GetObject(“LDAP://cn=Users,” & _
oRootLDAP.Get(“defaultNamingContext”))
‘ Allows processing to continue even if an error occurs (i.e. dup user)
‘ We put this below the CSV and AD information since processing can
‘ continue with a single bad record, but not if there is a problem with
‘ the CSV file or AD connection
on error resume next
do until oRecordSet.EOF ‘ Reads the values (cells) in the sInputFile file.
‘ ——— Start creating user account
‘ Read variable information from the CSV file
‘ and build everything needed to create the account
sLogon = oRecordSet.Fields.Item(0).value
sFirstName = oRecordSet.Fields.Item(1).value
sLastName = oRecordSet.Fields.Item(2).value
sDisplayName = sLastName&”, “&sFirstName
sPassword = oRecordSet.Fields.Item(3).value
sDescription = oRecordSet.Fields.Item(6).value
sHomeDrive = oRecordSet.Fields.Item(7).value
sHomeFolder = oRecordSet.Fields.Item(8).value
sLoginScript = oRecordSet.Fields.Item(9).value
‘ Build the User account
Set oNewUser = oContainer.Create(“User”,”cn=”&sFirstName&” “&SLastName)
oNewUser.put “sAMAccountName”,lcase(sLogon)
oNewUser.put “givenName”,sFirstName
oNewUser.put “sn”,sLastName
oNewUser.put “UserPrincipalName”,lcase(SLogon)&”@”&sDomain
oNewUser.put “DisplayName”,sDisplayName
oNewUser.put “name”,lcase(sLogon)
oNewUser.put “description?,sDescription
oNewUser.put “homeDrive?,sHomeDrive
oNewUser.put “homeDirectory?,sHomeFolder
oNewUser.put “scriptPath?,sLoginScript
‘ Write this information into Active Directory so we can
‘ modify the password and enable the user account
oNewUser.SetInfo
‘ Change the users password
oNewUser.SetPassword sPassword
oNewUser.Put “pwdLastSet”, 0
‘ Enable the user account
oNewUser.Put “userAccountControl”, 512
oNewUser.SetInfo
‘ Used only for debugging
‘if err.number = -2147019886 then
‘ msgbox “User logon ” & sLogon & “already exists”
‘End If
‘ ——— End of user account creation