Hi, i’m new in mssql programming…
i need a help.. please look my coding below.
if there is unnecessary line or bad coding..
PLEASE tell me
TQ.
CREATE PROCEDURE [test1] AS
Begin Tran
update jobdt set nstatusid=0 where nstatusid is null or nstatusid<0
IF @@ERROR <> 0 ROLLBACK TRAN
Declare myjobdun_cursor CURSOR FOR
SELECT nJobDTID, nStatusID FROM JobDT ORDER BY nJobDTID
IF @@ERROR <> 0 ROLLBACK TRAN
Declare @njobdtid int, @nstatusid int
OPEN myjobdun_cursor
FETCH NEXTFROM myjobdun_cursor
INTO @njobdtid, @nstatusid
IF @@ERROR <> 0 ROLLBACK TRAN
WHILE @@FETCH_STATUS =0
BEGIN
UPDATE JobDT SET nCumulatedQuantity= (SELECT SUM(nJobDunQuantity) FROM JobDunDT WHERE nJobDTID =@njobdtid) WHERE nJobDTID =@njobdtid
IF @@ERROR <> 0 ROLLBACK TRAN
if @nstatusid !=0
BEGIN
UPDATE JobDT SET nCumPrevious =(SELECT (ISNULL(nCumulatedQuantity,0) + ISNULL(nCumPrevious,0)) FROM JobDT WHERE nJobDTID =@njobdtid) WHERE nJobDTID =@nstatusid
IF @@ERROR <> 0 ROLLBACK TRAN
END