You only need one machine running W2K to implement Internet Connection Sharing (and that could be either W2K Professional or W2K Server). That W2K machine would host the Internet connection and it would just look like a gateway to the others.
Myexperience with upgrades has been variable and I now prefer to do a clean install if possible. But the only real 'gotchas' I've experienced have been hardware incompatibilities (particularly with CD-RW drives and modems). Microsoft makes a "Readiness Analyzer" tool that works pretty well in predicting which components, if any, are going to have problems.
The other annoyance about W2K is that the user interface will take a little getting used to - things are placed a little differently thanin NT4.
One other thought is that for a little over $100, you could get a hardware device to share the Internet connection so if you're doing the upgrade solely for Internet Connection Sharing, you may want to consider these other options.
paul